Update developer guide, removed unused code and CSS #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
Aug 23, 2024
CodyCBakerPhD
requested changes
Aug 23, 2024
|
Hm. I will investigate. |
|
@rly Nvm, it's failing on |
CodyCBakerPhD
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing the code base, I updated the developer guide and removed code and CSS that was used in SODA but not in GUIDE. In particular, the Guided Home Page manages uploaded vs non-uploaded datasets and has support for many tabs that are also radio buttons, but GUIDE does not track uploaded vs non-uploaded and has just the one tab "Existing Conversions". So I simplified the code. We can always reference SODA if we want to use any of those features, but I do not expect that we will.
There is still a lot more CSS left that is unused; I just removed what stood out as immediately removable after a search through the repo. I also cross-checked most of them with the SODA repo to make sure they were used in custom elements in their app (as opposed to an imported component).